update afragen/translations-updater with error caching/logging

[afragen]

Added API error caching for 60 min as GitHub API rate limits unauthenticated requests for 60 requests/hour. Leaves an entry in the debug.log

[afragen]

Fixes #200

[afragen]

Hopefully fixes #188

[ipajen]

@afragen

the #188 issue is solved in the fix.

But i am getting follow PHP warning when the 403 kicks in on language-pack.json

``Undefined property: stdClass::$name `

`wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/API.php:141
Fragen\Translations_Updater\Language_Pack_API->api()
wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Language_Pack_API.php:87
Fragen\Translations_Updater\Language_Pack_API->get_language_pack_json()
wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Language_Pack_API.php:56
Fragen\Translations_Updater\Language_Pack_API->get_language_pack()
wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Language_Pack.php:62
Fragen\Translations_Updater\Language_Pack->run()
wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Base.php:52
Fragen\Translations_Updater\Init->get_remote_repo_data()
wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Init.php:78
Fragen\Translations_Updater\Init->run()
wp-content/plugins/aspireupdate/aspire-update.php:76
aspireupdate_init_translations()
wp-includes/class-wp-hook.php:324
do_action('init')
wp-settings.php:704`

[afragen]

Well maybe it not quite the fix.

[afragen]

I'm thinking it might be better to return a WP_Error for a validation failure.

[ipajen]

Getting two PHP warnings now when 403 comes.

Undefined property: stdClass::$name | +wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/API.php:141

Undefined property: WP_Error::$slug | +wp-content/plugins/aspireupdate/vendor/afragen/translations-updater/src/Translations_Updater/Language_Pack.php:63

[ipajen]

But i see also in the debug logs

[17-Nov-2024 17:41:43 UTC] Translations Updater Error: (aspireupdate:main) - API rate limit exceeded for XXXIP. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

[afragen]

Is this with current change back to returning false?

afragen@7c4774e

[afragen]

Just finished an update to the error handling. It should now degrade gracefully and document API timeout errors in the error log.

[ipajen]

Tested on the https://github.com/afragen/aspireupdate/tree/error-cache-logging bransch and the PHP warnings are gone and it’s caching if the rate limit is hit so it will not pound the GitHub API.