Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: #710 changed copy_runfiles_to_bin behavior of ts_project if transpiler is set #716

Open
gzm0 opened this issue Oct 15, 2024 · 1 comment · May be fixed by #717
Open

[Bug]: #710 changed copy_runfiles_to_bin behavior of ts_project if transpiler is set #716

gzm0 opened this issue Oct 15, 2024 · 1 comment · May be fixed by #717
Labels
bug Something isn't working

Comments

@gzm0
Copy link
Contributor

gzm0 commented Oct 15, 2024

What happened?

When upgrading to 3.2.1 (from 3.2.0) the copy_runfiles_to_bin behavior of ts_project changes when transpiler is set:

ts_project(
  data = ["my-file.txt"],
  transpiler = swc,
)

Up until 3.2.0, my-file.txt gets copied to bin. After 3.2.1, it doesn't anymore (due to the refactor in #710).

Somewhat ironically, I expect this will fix #411 (there is more information in that bug for why this happens), but it is a breaking change.

Version

Development (host) and target OS/architectures:

Output of bazel --version: bazel 7.3.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 3.2.0 / 3.2.1

Language(s) and/or frameworks involved: None.

How to reproduce

No response

Any other information?

No response
@gzm0 gzm0 added the bug Something isn't working label Oct 15, 2024
@gzm0
Copy link
Contributor Author

gzm0 commented Oct 15, 2024

/cc @jbedard

I'm happy to help here if you need more infos. I think the toughest thing here is to figure out how we want the behavior to be (once that is settled, it's IIUC only flag wiring).

@gzm0 gzm0 linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: re-establish pre-3.2.1 copy_data_to_bin behavior gzm0/rules_ts
1 participant
@gzm0