fix: split on site-packages path segment when reporting conflicts #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding wheels via rules_pycross'
pycross_wheel_library
, the wheels end up inbazel-out
, rather than within the runfiles tree like when consuming from rules_python. To account for this, change the delimiter tosite-packages/
given that is the actual common ancestor in the path.This also changes to using the full paths for reporting the conflict to make it easier to see where the incoming conflict is from.
Closes #359
Changes are visible to end-users: yes
Use
site-packages/
as path delimiter when reporting venv package conflicts.Test plan
Run against https://github.com/tgeng/pycross_venv_bug_repro