Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop rattler_installs_packages for uv crates #412

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: drop rattler_installs_packages for uv crates #412

merged 1 commit into from
Oct 24, 2024

Conversation

mattem
Copy link
Member

@mattem mattem commented Oct 16, 2024

Drops the dependency on rattler_installs_packages in favour of the uv crates.

Note that while this works, the creates of uv do not officially support depending directly on the crates, however there is little overhead here, and is pinned to a fixed SHA.

Closes #307
Closes #344
Closes #345

Due to compilation issues under llvm, this diff also switches to musl for the toolchain binaries. We need to keep llvm for proc macros, unfortunately.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Drop dependency on rattler_installs_packages in favour of the uv crates.
Produce statically linked toolchain binaries via musl.

Test plan

  • New test cases added

py/private/py_binary.bzl Show resolved Hide resolved
@mattem mattem merged commit ca62068 into main Oct 24, 2024
11 of 12 checks passed
@mattem mattem deleted the use_uv branch October 24, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Switch to uv for venv creation and for pip compile [FR]: include (de)activation scripts in venvs
2 participants