Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dogfood our rules rather than rules_python #204

Merged
merged 1 commit into from
Oct 3, 2023
Merged

chore: dogfood our rules rather than rules_python #204

merged 1 commit into from
Oct 3, 2023

Conversation

alexeagle
Copy link
Member

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

@alexeagle
Copy link
Member Author

@mattem maybe it's like this on purpose for py_pytest_main to demonstrate that it works with rules_python#py_test ?

@mattem
Copy link
Member

mattem commented Oct 3, 2023

@mattem maybe it's like this on purpose for py_pytest_main to demonstrate that it works with rules_python#py_test ?

I don't think so, probably just not placing rules_py in the critical path.

CI failure here looks legit.

@alexeagle alexeagle merged commit 0945973 into main Oct 3, 2023
2 checks passed
@alexeagle alexeagle deleted the dogfood branch October 3, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@mattem mattem mattem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexeagle @mattem @thesayyn