fix: fix for issue #447

.github/workflows/ci.yaml

@@ -49,6 +49,7 @@ jobs:
  - 'e2e/pnpm_workspace_rerooted'
  - 'e2e/npm_translate_package_lock'
  - 'e2e/npm_translate_yarn_lock'
+ - 'e2e/package_json_module'
  - 'e2e/rules_foo'
  - 'e2e/js_image'
 

e2e/package_json_module/.bazelignore

@@ -0,0 +1 @@
+node_modules/

e2e/package_json_module/.bazelrc

@@ -0,0 +1,2 @@
+# import common bazelrc shared with e2e workspaces
+import %workspace%/../../.bazelrc.common

e2e/package_json_module/.bazelversion

@@ -0,0 +1 @@
+../../.bazelversion

e2e/package_json_module/BUILD.bazel

@@ -0,0 +1,14 @@
+load("@npm//:defs.bzl", "npm_link_all_packages")
+load("@npm//:mocha/package_json.bzl", mocha_bin = "bin")
+
+npm_link_all_packages(name = "node_modules")
+
+mocha_bin.mocha_test(
+ name = "test",
+ args = ["test.js"],
+ data = [
+ # package.json is required for node to pickup the "type": "module" field
+ "package.json",
+ ":test.js",
+ ],
+)

e2e/package_json_module/README.md

@@ -0,0 +1,9 @@
+e2e tests with special case of
+
+```
+"type": "module",
+```
+
+set in `package.json`.
+
+In particular, this is a regression test for issue https://github.com/aspect-build/rules_js/issues/447

e2e/package_json_module/WORKSPACE

@@ -0,0 +1,27 @@
+local_repository(
+ name = "aspect_rules_js",
+ path = "../..",
+)
+
+load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
+
+rules_js_dependencies()
+
+load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
+
+nodejs_register_toolchains(
+ name = "nodejs",
+ node_version = DEFAULT_NODE_VERSION,
+)
+
+load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
+
+npm_translate_lock(
+ name = "npm",
+ pnpm_lock = "//:pnpm-lock.yaml",
+ verify_node_modules_ignored = "//:.bazelignore",
+)
+
+load("@npm//:repositories.bzl", "npm_repositories")
+
+npm_repositories()

e2e/package_json_module/package.json

@@ -0,0 +1,7 @@
+{
+ "private": "true",
+ "type": "module",
+ "dependencies": {
+ "mocha": "10.0.0"
+ }
+}