Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backfill versions 8.7-9.0, 9.2, for completeness #12

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

jurraca
Copy link
Collaborator

@jurraca jurraca commented Sep 30, 2024

For completeness, adding the missing versions for rpki-client portable and openbsd so that we can build it for any version since 8.4. This doesn't have any immediate or operational value, but as we keep up with their releases, it's nice to have all the versions.
closes #10

Copy link
Collaborator

@fjahr fjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely good to have this!

I found one mismatch on the portable repo (see comment) and then for the openbsd repo I looked at the tags here: https://github.com/rpki-client/rpki-client-openbsd/tags but there almost all the hashes are different from what you found. Can you say where you got the hashes for openbsd from?

versions.nix Outdated
openbsd = "d64b7617dc536b6c76a0c87113c4586479c4a3d2";
};
"8.9" = {
portable = "ee15321f92158f5b78ca7da3b33a7a7d26fcf91d";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 70efa83594d4589521814fa782e1e453caf97697 as the portable hash for 8.9 here: https://github.com/rpki-client/rpki-client-portable/tags

@jurraca
Copy link
Collaborator Author

jurraca commented Oct 1, 2024

I... forgot about the openbsd release tags 🤦‍♂️ . I think I got stuck on the idea that they don't do releases or something. I went through and picked out the commits that bumped the version, and in a few cases used the subsequent ones if there was a correction to the release notes.

@fjahr
Copy link
Collaborator

fjahr commented Oct 1, 2024

ACK, looks all correct to me now.

@fjahr fjahr merged commit 0a01e84 into asmap:master Oct 1, 2024
1 check passed
@jurraca jurraca deleted the backfill-versions branch October 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport versions
2 participants