add pylint configuration and package #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylintrc generated with `--generate-rcfile` which outputs a ton of default config. I removed the empty settings and kept the stated defaults for the rest. Our disabled rules form CI are on line 209.
fjahr
reviewed
Nov 23, 2024
pylintrc
Outdated
| too-many-statements, | ||
| too-few-public-methods, | ||
| fixme, | ||
| too-many-positional, |
There was a problem hiding this comment.
Getting this error here:
pylintrc:1:0: W0012: Unknown option value for '--disable', expected a valid pylint message and got 'too-many-positional' (unknown-option-value)
There was a problem hiding this comment.
what pylint version you running? Looks like nixpkgs is on 3.1.1 (fairly far behind) which has this option, but 4.0.0 3.3.1 onwards has too-many-positional-arguments arg. 4.0.0 3.3.1 would be the version we should follow in this case.
There was a problem hiding this comment.
nixpkgs 24.11 release is around the corner (currently in beta) and has 3.3.1. I'll test it.
There was a problem hiding this comment.
seems like I tested this outside of the nix shell and there I have pylint 3.3.1, so yeah, using that should fix it.
There was a problem hiding this comment.
updated and tested locally with 3.3.1 👍
|
tACK 8dd314d Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylintrc generated with
--generate-rcfilewhich outputs a ton of default config. I removed the empty settings and kept the stated defaults for the rest. Our disabled rules form CI are on line 209. Would it be better to remove the default config settings?