Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ASmap for run 1730210400 #19

Merged
merged 1 commit into from
Nov 5, 2024
Merged

add ASmap for run 1730210400 #19

merged 1 commit into from
Nov 5, 2024

Conversation

jurraca
Copy link
Contributor

@jurraca jurraca commented Oct 31, 2024

This adds the asmap.dat result for the coordinated launch from #18 from epoch 1730210400. We had a match from 4 out of 5 participants in the coordinated launch.

To confirm the result of the encoding you can use asmap-tool.

$ shasum -a 256 1730210400_final_result.txt
8986e7baf0aea86b6b63766968d77edb384d1c332b23725596e18693235419ce  1730210400_final_result.txt

$ python3 contrib/asmap/asmap-tool.py encode 1730210400_final_result.txt 1730210400_asmap.dat

$ shasum -a 256 1730210400_asmap.dat
93afd5c0a82f82fca9988881f397739427c9c34bc1adb337e0d00978dcd1863a 1730210400_asmap.dat

@0xB10C
Copy link

0xB10C commented Nov 1, 2024

ACK acfd979

Encoding my final_results.txt I too get an asmap.dat file with the hash 93afd5c0a82f82fca9988881f397739427c9c34bc1adb337e0d00978dcd1863a. I checked that the file added here hashes to the 93afd5c0.. hash.

@0xB10C
Copy link

0xB10C commented Nov 1, 2024

I thought about making latest_asmap.dat a symlink of an asmap file. I think it should work for Linux an probably macOS too. However, it might not work for Windows.

@jurraca
Copy link
Contributor Author

jurraca commented Nov 1, 2024

However, it might not work for Windows.

yea let me see if I get a windows user to test this.

@dunxen
Copy link

dunxen commented Nov 4, 2024

ACK acfd979

@jurraca
Copy link
Contributor Author

jurraca commented Nov 5, 2024

However, it might not work for Windows.

Windows does not seem to resolve the symlink natively. There's some configuration to change ( enable Windows Developer mode) and maybe set git config core.symlinks true as well, but not sure. I'd like the opinion of someone who knows Windows better to confirm this. Is there a Core windows testing person?

@fjahr
Copy link
Collaborator

fjahr commented Nov 5, 2024

@0xB10C @jurraca The latest_asmap file exists primarily so we have a constant link to the latest file on GitHub for download that can be shared/documented like in the seeds readme: https://github.com/bitcoin/bitcoin/tree/master/contrib/seeds I tested this initially but GitHub doesn't follow symlinks so even if it would work on windows we still couldn't make it a symlink. Maybe there are more elegant ways to do this and I am happy to consider new idea but I don't want to add any additional dependency and this is simple and works for now.

@fjahr fjahr merged commit dcce69e into asmap:main Nov 5, 2024
1 check passed
@jurraca jurraca deleted the add-1730210400 branch November 5, 2024 12:42
@0xB10C
Copy link

0xB10C commented Nov 5, 2024

fwiw: I now run one of my monitoring nodes with -asmap=latest_asmap.dat (being 1730210400)

@fjahr
Copy link
Collaborator

fjahr commented Nov 5, 2024

fwiw: I now run one of my monitoring nodes with -asmap=latest_asmap.dat (being 1730210400)

Awesome! Please let us know if you see anything noteworthy, it will definitely be interesting for the embedding discussion in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants