Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASmap run 1724248800 #16

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add ASmap run 1724248800 #16

merged 1 commit into from
Aug 23, 2024

Conversation

jurraca
Copy link
Contributor

@jurraca jurraca commented Aug 22, 2024

This adds the asmap.dat result for the coordinated launch from #15 from the epoch 1724248800. We had a match from 6 out of 7 participants in the coordinated launch.

To confirm the result of the encoding you can use asmap-tool.

$ shasum -a 256 1724248800_final_result.txt
0236b4f8c6e023e3bd201996c49f9f10852be0ca7e5952a4ba26fc1c00b71153  1724248800_final_result.txt

$ python3 contrib/asmap/asmap-tool.py encode 1724248800_final_result.txt 1724248800_asmap.dat

$ shasum -a 256 1724248800_asmap.dat
dafaf52c1acd6e3f1e1e91d613c5fbbf7e9905e020ecfe101e381ce1a88dd84d 1724248800_asmap.dat

update latest_asmap.dat to be the same file
@fjahr
Copy link
Collaborator

fjahr commented Aug 22, 2024

To confirm the result of the encoding you also need to check out bitcoin/bitcoin#28793 to get the latest version of asmap-tool.

That PR was merged so you can now just link to the main repository.

@fjahr
Copy link
Collaborator

fjahr commented Aug 22, 2024

ACK

I have received the same hash: dafaf52c1acd6e3f1e1e91d613c5fbbf7e9905e020ecfe101e381ce1a88dd84d.

$ shasum -a 256 1724248800-final_result.txt
0236b4f8c6e023e3bd201996c49f9f10852be0ca7e5952a4ba26fc1c00b71153  1724248800-final_result.txt
$ python3 contrib/asmap/asmap-tool.py encode 1724248800-final_result.txt 1724248800_asmap.dat
$ shasum -a 256 1724248800_asmap.dat
dafaf52c1acd6e3f1e1e91d613c5fbbf7e9905e020ecfe101e381ce1a88dd84d  1724248800_asmap.dat

To other reviewers that may see this for the first time: This also edits a latest_asmap.dat file. It is just a copy of the timestamped file. We added this so there is a permanent (download) link to the latest asmap file that can be linked to in the seeder README and other places. There is a CI action that checks the hash of the latest asmap file (by timestamp) and the latest_asmap.dat file are equivalent: https://github.com/fjahr/asmap-data/blob/main/.github/workflows/latest_asmap.yml

Copy link

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ff14e5 🚀

$ shasum -a 256 final_result.txt
0236b4f8c6e023e3bd201996c49f9f10852be0ca7e5952a4ba26fc1c00b71153
$ python3 contrib/asmap/asmap-tool.py encode /projects/kartograf/out/1724248800/final_result.txt 1724248800_asmap.dat && shasum -a 256 1724248800_asmap.dat
dafaf52c1acd6e3f1e1e91d613c5fbbf7e9905e020ecfe101e381ce1a88dd84d  1724248800_asmap.dat

@Emzy
Copy link

Emzy commented Aug 23, 2024

ACK

$ sha256sum 1724248800_asmap.dat 
dafaf52c1acd6e3f1e1e91d613c5fbbf7e9905e020ecfe101e381ce1a88dd84d  1724248800_asmap.dat

@fjahr fjahr merged commit 71b95dd into asmap:main Aug 23, 2024
1 check passed
@Sjors
Copy link

Sjors commented Aug 26, 2024

Post merge ACK, will try running this on my node as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants