-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 7. #104
Support Symfony 7. #104
Conversation
It's deprecated since 5.3, so we could still support 5.3 and above right? |
Sorry for the noise, was struggling a bit with the dependencies for the tests. I think this is probably the cleanest. Drop support for PHP < 7.3 and Symfony < 5.3. We could also just skip ahead to PHP8.1 and Symfony 6 though. |
Thanks for fixing up the test runner config. I forgot that Symfony allowed the deprecation to span two major versions so 5.3 seems fine as a new minimum. Drupal 9 uses Symfony 4 which is why it is end of life now. Drupal 11 will be using Symfony 7 and we are looking to start work on the development branch of that, which is the reason I opened this PR. |
Also added argument types to the method, given that they are now on the interface since at least 5.3. |
Drupal 10 is Symfony 6 right? So I guess we could drop some legacy versions. |
Yes, Drupal 10 uses Symfony 6; we skipped Symfony 5. |
Thanks! |
I've bumped the version alias to 2.2-dev so you can prepare/test with Drupal. I'll tag a new release (2.2.0) after feedback. |
Thank you, works for me with SF 7.0 RC2 |
Thank you a lot! Just in time) https://github.com/symfony/symfony/releases/tag/v7.0.0 |
Symfony has dropped the
MASTER_REQUEST
constant in Symfony 7 so we have to switch toMAIN_REQUEST
and drop support for older versions of Symfony.