Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7. #104

Merged
merged 14 commits into from
Nov 14, 2023
Merged

Support Symfony 7. #104

merged 14 commits into from
Nov 14, 2023

Conversation

longwave
Copy link
Contributor

Symfony has dropped the MASTER_REQUEST constant in Symfony 7 so we have to switch to MAIN_REQUEST and drop support for older versions of Symfony.

@barryvdh
Copy link
Collaborator

It's deprecated since 5.3, so we could still support 5.3 and above right?

@barryvdh
Copy link
Collaborator

@barryvdh
Copy link
Collaborator

Sorry for the noise, was struggling a bit with the dependencies for the tests. I think this is probably the cleanest. Drop support for PHP < 7.3 and Symfony < 5.3.
This would allow support for Drupal 9 still, although that seems to be end-of-life.

We could also just skip ahead to PHP8.1 and Symfony 6 though.

@longwave
Copy link
Contributor Author

Thanks for fixing up the test runner config. I forgot that Symfony allowed the deprecation to span two major versions so 5.3 seems fine as a new minimum.

Drupal 9 uses Symfony 4 which is why it is end of life now. Drupal 11 will be using Symfony 7 and we are looking to start work on the development branch of that, which is the reason I opened this PR.

@longwave
Copy link
Contributor Author

Also added argument types to the method, given that they are now on the interface since at least 5.3.

@barryvdh
Copy link
Collaborator

Drupal 10 is Symfony 6 right? So I guess we could drop some legacy versions.

@longwave
Copy link
Contributor Author

Yes, Drupal 10 uses Symfony 6; we skipped Symfony 5.

@barryvdh barryvdh merged commit 4d6312c into asm89:master Nov 14, 2023
13 checks passed
@barryvdh
Copy link
Collaborator

barryvdh commented Nov 14, 2023

Thanks!

@barryvdh
Copy link
Collaborator

I've bumped the version alias to 2.2-dev so you can prepare/test with Drupal. I'll tag a new release (2.2.0) after feedback.

@andypost
Copy link

Thank you, works for me with SF 7.0 RC2

@barryvdh
Copy link
Collaborator

@andypost
Copy link

Thank you a lot! Just in time) https://github.com/symfony/symfony/releases/tag/v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants