Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Firebase #59

Merged
merged 12 commits into from
Jun 15, 2024
Merged

Downgrade Firebase #59

merged 12 commits into from
Jun 15, 2024

Conversation

jaggy
Copy link
Contributor

@jaggy jaggy commented May 11, 2024 •
edited
Loading

This PR fixes a couple of things:

  • Don't execute any Firebase code at all when the Firebase config is non-existent or invalid.
  • "Invalid Firebase config" showing up in the error logs.
  • Use a lower version of the Firebase package to support older versions of PHP.
  • Remove expired tokens when Firebase fails to send them out.
  • Add better logging when the APNs is invalid.

@jaggy jaggy changed the title Use a lower firebase package version Housekeeping. May 11, 2024
@jaggy jaggy changed the title Housekeeping. Housekeeping May 11, 2024
@jaggy jaggy marked this pull request as ready for review May 11, 2024 07:08
@jaggy jaggy changed the title Housekeeping Downgrade Firebase May 21, 2024
@luceos
Copy link
Contributor

luceos commented Jun 11, 2024

@askvortsov1 would you please be so kind to review 👍

@askvortsov1 askvortsov1 merged commit 7f312cd into askvortsov1:master Jun 15, 2024
8 checks passed
@luceos luceos deleted the downgrade-firebase-package branch June 16, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaggy @luceos @askvortsov1