Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandafluff #3

Open
wants to merge 3 commits into
base: pandafluff
Choose a base branch
from
Open

Pandafluff #3

wants to merge 3 commits into from

Conversation

fiferboy
Copy link

The beginning of a "touch" interface to Wesnoth. Swipe down menu and larger buttons so far.

Still needs:

  • disable mouse
  • drag scrolling on the map
  • other larger UI elements (list elements, check boxes, etc)

- Trigger a dialog on swipe down
- Remove the "Game" and "Action" menus from the game screen
@asimonov-im
Copy link
Owner

Looks pretty good. I made some comments on c56f807, just little things that seem like they may be leftovers?

@fiferboy
Copy link
Author

Yes, those are leftover from my original trace through the code to get SDL_USEREVENT to launch the dialog.

@asimonov-im
Copy link
Owner

I'd be happy to merge it after the cleanup.

@fiferboy
Copy link
Author

I have updated my branch with the clean up items we discussed.

@NichtJens
Copy link

I have not yet pulled and looked at what you did, but maybe it's worth noting that I made a sdl-controls.xml [1] for Wesnoth, that makes it rather playable ...

I added touchkey areas around the main map for directions (=scrolling the main map) and an escape button at the top right. The latter I needed because once one opens a right-click menu by holding it cannot be closed by clicking somewhere else (I guess that's a bug somewhere?!).

I also made a script to create the sdl-controls.xml [2] so one can easily adjust the direction button width.

As a side note:
I'm not sure if removing the cursor is really good, before drag scrolling works. Anyway, if one turns on "Show Color Cursors" in the Display preferences, the strange-looking tearing of the b/w cursor is gone... It does look quite nice then.

[1] https://github.com/NichtJens/wnbbpb-helper/blob/master/sdl-controls.xml
[2] https://github.com/NichtJens/wnbbpb-helper/blob/master/sdlcontrolxml.sh

@fiferboy
Copy link
Author

Interesting note about the color cursor.

I have some fixes that add in drag scrolling onto the play screen which works quite well and make it much more playable. I'm in the process of ironing out the bugs and play testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants