Some small text updates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It includes a link to the same postcode file.
asibs
reviewed
Mar 2, 2024
Comment on lines
+114
to
+117
| If different UPRNs within a single postcode have different constituencies, we know we might have a postcode where the exact | ||
| address is needed to determine the constituency. As the open UPRN data includes non-address UPRNs such as Street Records, | ||
| with no classification, it is possible for every address in the postcode to be in one constituency, but for all the UPRNs | ||
| to cover more than one constituency. |
There was a problem hiding this comment.
Thanks, this is a very useful clarification! 👍
asibs
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this repo, it's good to see others looking at things like this. I've made a few small changes, hope that's helpful/of interest. If y
As per mysociety/mapit.mysociety.org#116 I'd like to get UPRNs into MapIt at some point, even if we can't use them for human guidance or fully accurate results, one day perhaps we will. In our experiments in the past, I think we did get to a performant query of all UPRNs in a postcode, returning the areas matching across them.