Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force GoCD to build every commit (WIP) #76

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Force GoCD to build every commit (WIP) #76

wants to merge 7 commits into from

Commits on Oct 22, 2016

  1. Support for building every commit 

    This basically works by holding back commits until GoCD can
schedule them. This assumes that GoCD starts scheduling the given
commits right after the plugin gives them to the server. This
will prevent the case where GoCD is building one commit whichs
takes long time to build. Meanwhile other commits would be given
to GoCD and it would merge these commits. That would result some
of the commits to be skipped.

This is useful when using tools like Gerrit which should make
GoCD to build every change set and report the result back to Gerrit.
Without this feature GoCD will skip some changeset if the changeset
are related to each other.

This feature requires access to Go's pipeline API so that it can
check if the pipeline can be scheduled.

This will also require the pipeline to have only one stage. Otherwise
GoCD (tested on versions 16.2, 16.6) may require manual triggering of
the second stage even when pipeline isn't configured to behave like
this.
    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    c4a080e View commit details
    Browse the repository at this point in the history

  2. Refactor plugin setting parsing

    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    a31dc92 View commit details
    Browse the repository at this point in the history

  3. Refactor scm plugin settings handling

    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    2537527 View commit details
    Browse the repository at this point in the history

  4. Remove general plugin settings from plugins that don't require them 

    Only Gerrit uses plugin level settings for now.
    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    e043c4c View commit details
    Browse the repository at this point in the history

  5. Add support for checking if pipeline is building

    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    055475d View commit details
    Browse the repository at this point in the history

  6. Also check that pipeline jobs aren't running 

    Don't allow to start a build if there is something still building.
    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    65bad1e View commit details
    Browse the repository at this point in the history

  7. Improve pipeline building status unit tests

    @juhasipo
    juhasipo committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    8c6436e View commit details
    Browse the repository at this point in the history