[Cloud Security] fix flaky test

ashokaditya · Mar 5, 2024 · 15cdcf2 · 15cdcf2
1 parent f4bb26d
commit 15cdcf2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/cloud_security_posture/server/routes/benchmark_rules/bulk_action/utils.ts b/x-pack/plugins/cloud_security_posture/server/routes/benchmark_rules/bulk_action/utils.ts
@@ -42,8 +42,9 @@ const disableDetectionRules = async (
 ): Promise<string[]> => {
   const detectionRulesIdsToDisable = await getDetectionRuleIdsToDisable(detectionRules);
   if (!detectionRulesIdsToDisable.length) return [];
-  await detectionRulesClient.bulkDisableRules({ ids: detectionRulesIdsToDisable });
-  return detectionRulesIdsToDisable;
+  const uniqueDetectionRulesIdsToDisable = [...new Set(detectionRulesIdsToDisable)]; // Prevent muting the same rule twice.
+  await detectionRulesClient.bulkDisableRules({ ids: uniqueDetectionRulesIdsToDisable });
+  return uniqueDetectionRulesIdsToDisable;
 };
 
 export const getDetectionRules = async (

diff --git a/x-pack/test/cloud_security_posture_api/routes/csp_benchmark_rules_bulk_update.ts b/x-pack/test/cloud_security_posture_api/routes/csp_benchmark_rules_bulk_update.ts
@@ -93,8 +93,7 @@ export default function ({ getService }: FtrProviderContext) {
       log.debug('CSP plugin is initialized');
     });
 
-  // Failing: See https://github.com/elastic/kibana/issues/174204
-  describe.skip('Verify update csp rules states API', async () => {
+  describe('Verify update csp rules states API', async () => {
     before(async () => {
       await waitForPluginInitialized();
     });