-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Floor Temp, Humidity, Current Temp Sensors + Logging #57
Open
NewsGuyTor
wants to merge
19
commits into
asev:master
Choose a base branch
from
NewsGuyTor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add floor temperature sensors in HA, only for thermostats with floor temperature sensors
Add humidity sensor
Closed
Code improvements from @chribba021. Adds Current Temp Sensors + Logging
NewsGuyTor
changed the title
Add Floor Temperature Sensor
Add Floor Temp, Humidity, Current Temp Sensors + Logging
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several useful sensors in HA. Solves #55 and #56
The floor temperature or humidity sensors will only be added for thermostats that actually has floor temperature/humidity sensors working in Uponor (Room - Room Settings - Advanced Room Settings). Thanks to @vali-ballertv / @valentinlup for the humidity sensor code.
This also adds a sensor for Current temperature, for use in cards or helpers. Not to mention improved logging. Thanks to @chribba021 for that code.