Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor improvements for osx compat #69

Closed

Conversation

andreaTP
Copy link

Tweaks and improvements of the template after #68

I believe that this should also fix asdf-vm/actions#548

@andreaTP andreaTP force-pushed the mac-cross-compat-improvements branch from 501476e to 672a624 Compare April 20, 2023 10:40
@andreaTP andreaTP changed the title Minor improvements for osx compat fix: minor improvements for osx compat Apr 20, 2023
@jthegedus
Copy link
Collaborator

Thanks for taking the time to PR this, but I don't believe it is the right solution to this problem.

It seems the template had an issue with the latest-stable sed command which was fixed in #65. This sed issue was causing the macos runner test failures because it couldn't resolve the version properly from that script.

The changes proposed here change much more than what would have been required to resolve that issue. The change from .tar.gz. to .zip for instance. This template is just a starting point for plugin authors, changes to the file type, decompression etc are expected to be done on a case by case basis, this plugin template cannot cover it all.

If you find more universal solutions, please raise issues to discuss or further PRs, contributions and discussions are welcome!

@jthegedus jthegedus closed this Apr 23, 2023
@andreaTP
Copy link
Author

Make sense to me, thanks for getting back! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] MacOS build replaces version with literal https in download URL
2 participants