refactor(string): 文字列のリファクタリング #858
Merged
+313
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for js-primer ready! Built with commit adf429b |
Open
azu
commented
Jun 30, 2019
| tag(`template ${0} literal ${1}`); | ||
| ``` | ||
|
|
||
| しかし、`()`ではなく ``` タグ関数`テンプレート` ``` と記述することで、`タグ関数`が受け取る引数にはタグ付きテンプレート向けの値が渡ってきます。 |
There was a problem hiding this comment.
https://qiita.com/natecotus/items/be28e1c7111270d9207d この辺。
タグ関数とはって説明する前にタグ関数というワード使ってるのが良くなかった。
azu
commented
Jun 30, 2019
| return strings.reduce((result, str, i) => { | ||
| console.log([result, values[i - 1], str]); |
There was a problem hiding this comment.
reduceの挙動を説明するようのログを入れた
azu
commented
Jun 30, 2019
|
|
||
| [文字列とUnicode]: ../string-unicode/README.md | ||
| [エスケープシーケンス]: https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/String#%E3%82%A8%E3%82%B9%E3%82%B1%E3%83%BC%E3%83%97%E3%82%B7%E3%83%BC%E3%82%B1%E3%83%B3%E3%82%B9 | ||
| [twitter-text]: https://github.com/twitter/twitter-text "twitter/twitter-text: Twitter Text Libraries" |
azu
commented
Jul 21, 2019
|
|
||
| <!-- 評価とコンパイルは仕様から来てる用語 https://tc39.es/ecma262/#sec-pattern --> | ||
|
|
||
| 正規表現リテラルと`RegExp`コンストラクタの違いとして、正規表現のパターンが評価（コンパイル）されるタイミングの違いがあります。 |
There was a problem hiding this comment.
評価とコンパイルは仕様から来てる用語 https://tc39.es/ecma262/#sec-pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #208
fix #785
Ref #813