corrections of graphs for Algorithms 15 and 14 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Pascal,
apply my current Pull Request to correct two graphs of Algorithm No. 15 and No. 14, please.
Currently, the operators' graph for Algorithm No. 15 looks like this:
The view is a bit misleading, as it suggests that the 5th and 6th operators modulate the both the 2nd and 4th operators simultaneously, but originally the 5th and 6th operators only modulate the 4th operator, not the 2nd one. Therefore, I slightly modified the image of the Algorithm No. 15 to the following:
Furthermore, the image of the Algorithm No. 14 currently looks like it below:
However, if we compare this with the new graph of the Algorithm No. 15, the view might be confusing a bit, because there is only one essential difference between the two algorithms: namely, in the Algorithm No. 15, the 2nd operator has a feedback branch, while in the Algorithm No. 14, the 6th operator has a feedback branch; otherwise, the connection of the operators with each other is the same in both algorithms. So, for the sake of uniformity, I also modified the graph for the Algorithm No. 14 to this one:
Thank you in advance - and special thanks for releasing the new version 0.9.7!:)