Merge pull request #346 from voidshine/use_param_name_as_id

Fix parameter remote control in Bitwig by using name as parameter ID
asb2m10 · Jun 21, 2022 · 04aeb0e · 04aeb0e
2 parents 7e0a725 + 9bcdec3
commit 04aeb0e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Source/PluginParam.cpp b/Source/PluginParam.cpp
@@ -331,6 +331,7 @@ float CtrlFloat::getValueHost() {
 }
 
 void CtrlFloat::setValueHost(float v) {
+    TRACE("float set idx=%d v=%f", idx, v);
     *vPointer = v;
 }
 
@@ -364,7 +365,7 @@ void CtrlDX::setValueHost(float f) {
 }
 
 void CtrlDX::setValue(int v) {
-    TRACE("setting value %d %d", dxOffset, v);
+    TRACE("setting value idx=%d dxOffset=%d v=%d", idx, dxOffset, v);
     dxValue = v;
     if (dxOffset >= 0) {
         if (parent != NULL)
@@ -628,7 +629,7 @@ void DexedAudioProcessor::setDxValue(int offset, int v) {
         packOpSwitch();
         v = data[155];
     } else if ( data[offset] != v ) {
-        TRACE("setting dx %d %d", offset, v);
+        TRACE("setting dx offset=%d v=%d", offset, v);
         data[offset] = v;
     } else {
         TRACE("ignoring dx7 same values %d %d", offset, v);
@@ -670,6 +671,7 @@ float DexedAudioProcessor::getParameter(int index) {
 }
 
 void DexedAudioProcessor::setParameter(int index, float newValue) {
+    TRACE("setParameter index=%d newValue=%f", index, newValue);
     forceRefreshUI = true;
     ctrl[index]->setValueHost(newValue);
 }
@@ -726,6 +728,10 @@ const String DexedAudioProcessor::getParameterText(int index) {
     return ctrl[index]->getValueDisplay();
 }
 
+String DexedAudioProcessor::getParameterID(int index) {
+    return getParameterName(index);
+}
+
 void DexedAudioProcessor::loadPreference() {
     File propFile = DexedAudioProcessor::dexedAppDir.getChildFile("Dexed.xml");
     PropertiesFile::Options prefOptions;

diff --git a/Source/PluginProcessor.h b/Source/PluginProcessor.h
@@ -210,6 +210,7 @@ public :
     void setParameter (int index, float newValue);
     const String getParameterName (int index);
     const String getParameterText (int index);
+    String getParameterID (int index) override;
 
     const String getInputChannelName (int channelIndex) const;
     const String getOutputChannelName (int channelIndex) const;