Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on failure, don't emit successful exit status #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

on failure, don't emit successful exit status #26

wants to merge 2 commits into from

Conversation

ryneches
Copy link

@ryneches ryneches commented Feb 6, 2018

System.exit(0) should only indicate a successful exit. Using exit status of 1 to be consistent with other parts of the codebase.

@arvestad
Copy link
Owner

arvestad commented Feb 6, 2018

Thanks for contributions! I don't understand the reason for calling Runtime.halt(1) — why is not exit(1) sufficient?

arvestad
arvestad approved these changes Feb 7, 2018
View reviewed changes
Copy link
Owner

@arvestad arvestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I this first diff I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvestad arvestad arvestad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryneches @arvestad