fix bug #264
Merged
fix bug #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfitz
approved these changes
Oct 30, 2023
| @@ -210,3 +210,14 @@ def test_get_attributes_from_person(): | |||
| assert pid == "chris" | |||
| assert attributes["hid"] == "A" | |||
| assert attributes["vehicles"] == {"car": "chris"} | |||
|
|
|||
|
|
|||
| def test_get_float_attribute_from_person(): | |||
There was a problem hiding this comment.
When you ran this test before fixing the bug, did it throw an exception?
There was a problem hiding this comment.
it was trying to cast a lxml element as float (float(attr)), instead of the element value (attr.text)
|
@Theodore-Chatziioannou you need to run pre-commit locally! |
|
|
hmm, pre-commit should have fixed this issue when you first committed (assuming you have run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #263 .
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.