-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup micromamba to miniconda #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other benefit of a separated composite action is that users can use that action as a step in any arbitrary job they might like to create outside the scope of the reusable workflows. |
mfitz
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to using
miniconda
rather thanmicromamba
wherever we are installing the development environment of the "calling" repository. This is necessary so that we havemamba
/conda
on PATH, which you don't get withmicromamba
.It does bloat the jobs slightly more, but environment caching is in place to hopefully mitigate that.
I've also reduced code duplication, but at the cost of a slightly circular dependency. The "composite action" containing all the stuff to create a new environment is now in
actions
and is called by its URL from the reusable workflows. This is working just fine in my test repository jobs but does mean that the composite action version needs to be updated from this branch name tomain
before merging this PR (I had to use this branch name so the whole pipeline works in my test repo).