Assessment page no streams #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-sa
reviewed
Aug 9, 2023
|
Updated the message for the comments. Page now looks like this |
Exilliar
added a commit
that referenced
this pull request
Aug 9, 2023
* fixed issue with material total values (#219) * fixed issue with material total values * updated version number * decimals removed from materials breakdown chart * delete report issue (#221) * fixed delete, made it display speckle error message when the issue is out of our control * updated vesrion # * Rw/bug/model saving (#223) * fixed issue with material total values * mostly fixed, just something weird going on with uploading the objects * some more testing * fixed issue with models not saving properly * updated version # and message * clean up * messed around with how much we send to speckle at one time so that we don't break the arup speckle server * updated viewer version (#227) * Rw/feat/material selection (#226) * made most of the UI * started to work on small-ish refactor * very basic material selection working * transport step working (hopefully) * report review working (I think) * fixed issues with carbon calc * uploading works, updating almost works * updating a report is now working * custom material grouping working * grouping by diff params working * deleted commented out code and funcs that are no longer needed * removed useless variables * removed console.logs and some imports that are no longer used * buildups work, updated models with buildups works * cleanup * removed some stuff that is no longer needed * fixed bug * updated version update messages * chips on expandmaterialtype now filter objects in renderer * fixed issue with large models running out of memory * Rw/dev/parameter selection 2 (#229) * added in 'undefined' option to filters that need it * updated version # and dialog * Assessment page no streams (#231) * fixed issue * updated for pr comments
Exilliar
added a commit
that referenced
this pull request
Oct 3, 2023
* fixed issue with material total values (#219) * fixed issue with material total values * updated version number * decimals removed from materials breakdown chart * delete report issue (#221) * fixed delete, made it display speckle error message when the issue is out of our control * updated vesrion # * Rw/bug/model saving (#223) * fixed issue with material total values * mostly fixed, just something weird going on with uploading the objects * some more testing * fixed issue with models not saving properly * updated version # and message * clean up * messed around with how much we send to speckle at one time so that we don't break the arup speckle server * updated viewer version (#227) * Rw/feat/material selection (#226) * made most of the UI * started to work on small-ish refactor * very basic material selection working * transport step working (hopefully) * report review working (I think) * fixed issues with carbon calc * uploading works, updating almost works * updating a report is now working * custom material grouping working * grouping by diff params working * deleted commented out code and funcs that are no longer needed * removed useless variables * removed console.logs and some imports that are no longer used * buildups work, updated models with buildups works * cleanup * removed some stuff that is no longer needed * fixed bug * updated version update messages * chips on expandmaterialtype now filter objects in renderer * fixed issue with large models running out of memory * Rw/dev/parameter selection 2 (#229) * added in 'undefined' option to filters that need it * updated version # and dialog * Assessment page no streams (#231) * fixed issue * updated for pr comments * report sharing (#233) * added dialog to get share link * user given option to change server if they're on the wrong one for the report they're trying to view, user redirected to login if they're not signed in and then sent back to report once signed in * removed console logs * couple small last changes. Also fixed the 'no streams' page flashing up on the assessment page * updated version # * moved share button on report view page * login redirect (#234) * updated loading-container to take additional messages, updated login to redirect users back to where they wanted to go after logging in * small change to button on assessment view button * updated version number * addressed comment
ro-sa
added a commit
that referenced
this pull request
Nov 14, 2023
* fixed issue with material total values (#219) * fixed issue with material total values * updated version number * decimals removed from materials breakdown chart * delete report issue (#221) * fixed delete, made it display speckle error message when the issue is out of our control * updated vesrion # * Rw/bug/model saving (#223) * fixed issue with material total values * mostly fixed, just something weird going on with uploading the objects * some more testing * fixed issue with models not saving properly * updated version # and message * clean up * messed around with how much we send to speckle at one time so that we don't break the arup speckle server * updated viewer version (#227) * Rw/feat/material selection (#226) * made most of the UI * started to work on small-ish refactor * very basic material selection working * transport step working (hopefully) * report review working (I think) * fixed issues with carbon calc * uploading works, updating almost works * updating a report is now working * custom material grouping working * grouping by diff params working * deleted commented out code and funcs that are no longer needed * removed useless variables * removed console.logs and some imports that are no longer used * buildups work, updated models with buildups works * cleanup * removed some stuff that is no longer needed * fixed bug * updated version update messages * chips on expandmaterialtype now filter objects in renderer * fixed issue with large models running out of memory * Rw/dev/parameter selection 2 (#229) * added in 'undefined' option to filters that need it * updated version # and dialog * Assessment page no streams (#231) * fixed issue * updated for pr comments * report sharing (#233) * added dialog to get share link * user given option to change server if they're on the wrong one for the report they're trying to view, user redirected to login if they're not signed in and then sent back to report once signed in * removed console logs * couple small last changes. Also fixed the 'no streams' page flashing up on the assessment page * updated version # * moved share button on report view page * login redirect (#234) * updated loading-container to take additional messages, updated login to redirect users back to where they wanted to go after logging in * small change to button on assessment view button * updated version number * addressed comment * Move back button (#236) * correct spelling error * change back button location * update package json --------- Co-authored-by: Rory Webber <[email protected]> Co-authored-by: Exilliar <[email protected]> Co-authored-by: Exilliar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be the first comment we get from basically everyone is that the "assessment page is just blank". Typically this is just because the user has not been added to any streams. Added in a check for this, and if the user is not added to any streams then a message appears telling the user to add themselves to a stream.
Very quick fix, probably some issues with the wording (happy to make any changes to that). Probably also a better way that we could handle this, but I think that this should work for now.
Screenshot of the message:
Added in a small bit that makes it so that if the user is on an arup server (just checked by seeing if
arupis in the url) then the user will be linked to the Arup Speckle docs, otherwise they will be linked to the general Speckle docs.