Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adsec-1714 fix for missing ACI codes #95

Merged
merged 5 commits into from
May 20, 2024
Merged

adsec-1714 fix for missing ACI codes #95

merged 5 commits into from
May 20, 2024

Conversation

DominikaLos
Copy link
Collaborator

No description provided.

@DominikaLos DominikaLos changed the title adsec gh-1714 fix for missing ACI codes adsec-1714 fix for missing ACI codes May 8, 2024
vilayatk
vilayatk suggested changes May 8, 2024
View reviewed changes
Copy link

@vilayatk vilayatk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Dominica, I'm waiting for tests to be added

@DominikaLos
Copy link
Collaborator Author

As discussed with Dominica, I'm waiting for tests to be added

ready to review

@DominikaLos DominikaLos requested review from vilayatk and removed request for tlmnrnhrdt May 13, 2024 08:55
@DominikaLos DominikaLos merged commit 5956947 into main May 20, 2024
2 checks passed
@DominikaLos DominikaLos deleted the task/AdsecGH-1714 branch May 20, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandeepArup SandeepArup SandeepArup approved these changes

@vilayatk vilayatk vilayatk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominikaLos @SandeepArup @vilayatk