Skip to content

Commit

Permalink
Correct dependencies of GlobalAttributes (project-chip#31798)
Browse files Browse the repository at this point in the history
* Correct dependencies of GlobalAttributes

* Fix comment
  • Loading branch information
andy31415 authored Feb 1, 2024
1 parent d27d65e commit cfd1551
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,12 @@ source_set("paths") {
source_set("global-attributes") {
sources = [ "GlobalAttributes.h" ]

# This also depends on zap-generated code which is currently impossible to split outs
public_deps = [ "${chip_root}/src/lib/support" ]
# This also depends on zap-generated code which is currently impossible to split out
# as a dependency
public_deps = [
":app_config",
"${chip_root}/src/lib/support",
]
}

source_set("pre-encoded-value") {
Expand Down
1 change: 1 addition & 0 deletions src/app/GlobalAttributes.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#pragma once

#include <app-common/zap-generated/ids/Attributes.h>
#include <app/AppConfig.h>
#include <lib/support/CodeUtils.h>

namespace chip {
Expand Down

0 comments on commit cfd1551

Please sign in to comment.