Do not apply udev-monitor-set-timeout! to #f values. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to commit 980fe40, which changed the default timeout-sec and timeout-usec values to #f, with the behavior of waiting indefinitely for an event. * modules/udev/monitor.scm (make-udev-monitor): Filter out arguments whose values are #f.
|
I think I'll want to revisit this fix; but I don't have an immediate solution. One problem I see is that if someone specifies #:timeout-sec #f and #:timeout-usecs 100, the udev-monitor-remove-filters! procedure would now be called with usecs as secs, silently. I think I should handle #f values in udev-monitor-remove-filters! in C. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to commit 980fe40, which changed the default timeout-sec and timeout-usec values to #f, with the behavior of waiting indefinitely for an event.