Udev monitor improvements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modules/udev/monitor.scm (make-udev-monitor): Apply udev-monitor-set-error-callback! to the error-callback default procedure, no the callback one.
* libguile-udev/udev-monitor-func.c (udev_monitor_scanner): Fix typo.
Previously, it would default to use a 0 s timeout, which for select means that it doesn't block (it would poll continuously and waste CPU). This change unifies the make-udev-monitor/udev-monitor-set-timeout! interface with that of Guile's select procedure. * NEWS: Update news. * doc/guile-udev.texi (API Reference): Update doc. * examples/device-listener.scm (main) <make-udev-monitor>: Remove timeout arguments. * libguile-udev/udev-monitor-func.c (udev-monitor-set-timeout!): Make timeout arguments optional. Update doc. Streamline definition, removing all arguments validation, which is now handled by scm_select. * libguile-udev/udev-monitor-func.c (select_args_data): New struct. (call_select, false_on_exception): New procedures. (udev_monitor_scanner): Replace C select call with scm_select call, adjusting the rest accordingly. * libguile-udev/udev-monitor-type.h: Replace timeout member with new 'secs' and 'usecs' ones. * libguile-udev/udev-monitor-type.c (gudev_monitor_to_scm): Set default values of secs and usecs to SCM_BOOL_F. * modules/udev/monitor.scm (make-udev-monitor): Do not specify default values for filter, timeout-sec and timeout-usec keyword arguments. Update doc. Fixes: artyom-poptsov#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5.