Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap write arguments #1812

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Swap write arguments #1812

merged 6 commits into from
Nov 25, 2024

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented Nov 23, 2024

Description

Swap write arguments.
Advantages:

  1. pipes
  2. alias

Type of change

  • Code cleanup
  • Unit tests (added or updated unit-tests)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (implementation update, or general performance enhancements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (documentation-related additions)

@github-actions github-actions bot added documentation Improvements or additions to documentation library Issues related to the standard library unit-test Unit tests rosetta code Issues and PRs related to Rosetta Code snippets → Files labels Nov 23, 2024
@drkameleon drkameleon self-requested a review November 25, 2024 07:11
drkameleon
drkameleon reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@drkameleon drkameleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking into the PR (with some slightly... delay admittedly lol)

Great job! 😃

I do like the look of it and the result: it obviously makes much more sense, even visually.

If you could make the few fixes that I have spotted above (mainly having to do with the exact same thing: precedence), that would be awesome. 😉

And then I'll merge! 🚀

examples/rosetta/remove lines from a file.art Outdated Show resolved Hide resolved
tools/gendep.art Outdated Show resolved Hide resolved
tools/rc.art Outdated Show resolved Hide resolved
tools/sitegen.art Outdated Show resolved Hide resolved
tools/sitegen.art Outdated Show resolved Hide resolved
Eloitor and others added 5 commits November 25, 2024 09:19
@Eloitor @drkameleon
Update examples/rosetta/remove lines from a file.art
8e42cd8 
Co-authored-by: Yanis Zafirópulos <[email protected]>
@Eloitor @drkameleon
Update tools/gendep.art
d521312 
Co-authored-by: Yanis Zafirópulos <[email protected]>
@Eloitor @drkameleon
Update tools/sitegen.art
ca92d62 
Co-authored-by: Yanis Zafirópulos <[email protected]>
@Eloitor @drkameleon
Update tools/sitegen.art
1a58138 
Co-authored-by: Yanis Zafirópulos <[email protected]>
@Eloitor @drkameleon
Update tools/rc.art
4b642ab 
Co-authored-by: Yanis Zafirópulos <[email protected]>
drkameleon
drkameleon approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@drkameleon drkameleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 😉

@drkameleon
Copy link
Collaborator

And... ready to merge! 🚀

@drkameleon drkameleon merged commit a004037 into arturo-lang:master Nov 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drkameleon drkameleon drkameleon approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation → Files library Issues related to the standard library rosetta code Issues and PRs related to Rosetta Code snippets unit-test Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eloitor @drkameleon