MSSQL FF - TopicSuffix (#391)

artie-labs · May 18, 2024 · de94e70 · de94e70
1 parent ca97434
commit de94e70
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/sources/mssql/adapter/adapter.go b/sources/mssql/adapter/adapter.go
@@ -3,8 +3,6 @@ package adapter
 import (
 	"database/sql"
 	"fmt"
-	"strings"
-
 	"github.com/artie-labs/transfer/lib/ptr"
 
 	"github.com/artie-labs/reader/config"
@@ -62,7 +60,7 @@ func (m MSSQLAdapter) TableName() string {
 }
 
 func (m MSSQLAdapter) TopicSuffix() string {
-	return fmt.Sprintf("%s.%s.%s", m.dbName, m.table.Schema, strings.ReplaceAll(m.table.Name, `"`, ``))
+	return fmt.Sprintf("%s.%s.%s", m.dbName, m.table.Schema, m.table.Name)
 }
 
 func (m MSSQLAdapter) FieldConverters() []transformer.FieldConverter {

diff --git a/sources/mysql/adapter/adapter.go b/sources/mysql/adapter/adapter.go
@@ -4,7 +4,6 @@ import (
 	"database/sql"
 	"fmt"
 	"log/slog"
-	"strings"
 
 	"github.com/artie-labs/reader/config"
 	"github.com/artie-labs/reader/lib/debezium/converters"
@@ -67,7 +66,7 @@ func (m MySQLAdapter) TableName() string {
 }
 
 func (m MySQLAdapter) TopicSuffix() string {
-	return fmt.Sprintf("%s.%s", m.dbName, strings.ReplaceAll(m.table.Name, `"`, ``))
+	return fmt.Sprintf("%s.%s", m.dbName, m.table.Name)
 }
 
 func (m MySQLAdapter) FieldConverters() []transformer.FieldConverter {

diff --git a/sources/mysql/adapter/adapter_test.go b/sources/mysql/adapter/adapter_test.go
@@ -36,7 +36,7 @@ func TestMySQLAdapter_TopicSuffix(t *testing.T) {
 		},
 		{
 			table: mysql.Table{
-				Name: `"PublicStatus"`,
+				Name: "PublicStatus",
 			},
 			expected: "db.PublicStatus",
 		},

diff --git a/sources/postgres/adapter/adapter.go b/sources/postgres/adapter/adapter.go
@@ -4,7 +4,6 @@ import (
 	"database/sql"
 	"fmt"
 	"log/slog"
-	"strings"
 
 	"github.com/artie-labs/reader/config"
 	"github.com/artie-labs/reader/lib/debezium/converters"
@@ -60,7 +59,7 @@ func (p PostgresAdapter) TableName() string {
 }
 
 func (p PostgresAdapter) TopicSuffix() string {
-	return fmt.Sprintf("%s.%s", p.table.Schema, strings.ReplaceAll(p.table.Name, `"`, ``))
+	return fmt.Sprintf("%s.%s", p.table.Schema, p.table.Name)
 }
 
 func (p PostgresAdapter) FieldConverters() []transformer.FieldConverter {

diff --git a/sources/postgres/adapter/adapter_test.go b/sources/postgres/adapter/adapter_test.go
@@ -35,7 +35,7 @@ func TestPostgresAdapter_TopicSuffix(t *testing.T) {
 		},
 		{
 			table: postgres.Table{
-				Name:   `"PublicStatus"`,
+				Name:   "PublicStatus",
 				Schema: "schema2",
 			},
 			expectedTopicName: "schema2.PublicStatus",