[kafka] Remove context.DeadlineExceeded from retryable errors (#339)

artie-labs · Apr 4, 2024 · a674c6d · a674c6d
1 parent 9a51b75
commit a674c6d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/lib/kafkalib/errors.go b/lib/kafkalib/errors.go
@@ -1,7 +1,6 @@
 package kafkalib
 
 import (
-	"context"
 	"errors"
 	"log/slog"
 	"strings"
@@ -35,16 +34,5 @@ func isRetryableError(err error) bool {
 		return false
 	}
 
-	retryableErrs := []error{
-		context.DeadlineExceeded,
-		kafka.TopicAuthorizationFailed,
-	}
-
-	for _, retryableErr := range retryableErrs {
-		if errors.Is(err, retryableErr) {
-			return true
-		}
-	}
-
-	return false
+	return errors.Is(err, kafka.TopicAuthorizationFailed)
 }
diff --git a/lib/kafkalib/errors_test.go b/lib/kafkalib/errors_test.go
@@ -1,7 +1,6 @@
 package kafkalib
 
 import (
-	"context"
 	"fmt"
 	"testing"
 
@@ -62,10 +61,6 @@ func TestIsRetryableError(t *testing.T) {
 			err:      kafka.TopicAuthorizationFailed,
 			expected: true,
 		},
-		{
-			err:      context.DeadlineExceeded,
-			expected: true,
-		},
 		{
 			err:      kafka.MessageSizeTooLarge,
 			expected: false,