[postgres] Emit float32 values for real columns (#298)

artie-labs · Mar 18, 2024 · 760362b · 760362b
1 parent 98cfb38
commit 760362b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/integration_tests/postgres/main.go b/integration_tests/postgres/main.go
@@ -687,7 +687,7 @@ const expectedPayloadTemplate = `{
 				"x": 12.34,
 				"y": 56.78
 			},
-			"c_real": 45.678001403808594,
+			"c_real": 45.678,
 			"c_serial": 1000000123,
 			"c_smallint": 32767,
 			"c_text": "QWERTYUIOP",

diff --git a/lib/debezium/converters/passthrough.go b/lib/debezium/converters/passthrough.go
@@ -78,10 +78,10 @@ func (FloatPassthrough) ToField(name string) debezium.Field {
 
 func (FloatPassthrough) Convert(value any) (any, error) {
 	switch castValue := value.(type) {
-	case float32, float64:
+	case float32:
 		return castValue, nil
 	}
-	return nil, fmt.Errorf("expected float32/float64 got %T with value: %v", value, value)
+	return nil, fmt.Errorf("expected float32 got %T with value: %v", value, value)
 }
 
 // float32, float64 -> float64

diff --git a/lib/postgres/parse/parse.go b/lib/postgres/parse/parse.go
@@ -23,6 +23,14 @@ func ParseValue(colKind schema.DataType, value any) (any, error) {
 			return valString, nil
 		}
 		return nil, fmt.Errorf("value: %v not of string type for bit", value)
+	case schema.Real:
+		float64Value, ok := value.(float64)
+		if !ok {
+			return nil, fmt.Errorf("expected float64 got %T with value: %v", value, value)
+		}
+		// pgx returns `real`s as float64 even though they are always 32 bits
+		// https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-NUMERIC
+		return float32(float64Value), nil
 	case schema.UserDefinedText:
 		stringSlice, isOk := value.(string)
 		if !isOk {