Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broker page refreshes automatically upon broker creation #286

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Msarawan
Copy link
Collaborator

fixed the bug where the broker page refreshes automatically upon broker creation using useK8sWatchResource hook.

fixes: #218

@Msarawan Msarawan added the bug Something isn't working label Sep 12, 2024
@Msarawan Msarawan added this to the Stabilize the UI milestone Sep 12, 2024
@Msarawan Msarawan self-assigned this Sep 12, 2024
Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested it and it addresses the issue perfectly. Good job. It needs a bit of polish with some conflicts to solve and you're good to go.

@Msarawan Msarawan force-pushed the automatic-refresh-broker-page branch 2 times, most recently from 4c11979 to 63cc293 Compare September 12, 2024 09:21
@Msarawan Msarawan marked this pull request as ready for review September 12, 2024 09:21
…er creation

fixed the bug where the broker page refreshes automatically upon broker creation.
and updated the unit tests.
Copy link
Collaborator

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lavocatt lavocatt merged commit 3985c9e into artemiscloud:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a broker, the broker page doesn't refresh automatically
2 participants