[#226] better naming for generic resource #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavocatt
force-pushed
the
naming
branch
3 times, most recently
from
c94344e
to
0b2109f
Compare
The generic resource K8sResourceKind was composed from a BrokerCR and a generic data field. This definition was wrong since it was used to recover generic fields such as CertManager results. Now it is named K8sResourceCommonWithData and is composed from a K8sResourceCommon plus a generic data field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic resource K8sResourceKind was composed from a BrokerCR and a generic data field. This definition was wrong since it was used to recover generic fields such as CertManager results.
Now it is named K8sResourceCommonWithData and is composed from a K8sResourceCommon plus a generic data field.
fixes #226