[#192] support multiple hosts for the PEM case #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaohoward
previously approved these changes
Aug 14, 2024
lavocatt
force-pushed
the
multiplepemhost
branch
from
b2ccc5a
to
2704da0
Compare
lavocatt
force-pushed
the
multiplepemhost
branch
from
2704da0
to
63588d4
Compare
|
@gaohoward I had to rebase the PR, can you give it another check please? |
lavocatt
force-pushed
the
multiplepemhost
branch
3 times, most recently
from
2055498
to
e280d75
Compare
Add support for multiple hosts to be exposed via an ingress when the user selects several replicas. Each pod gets exposed and has its own url to get connected to. The connectivity helper shows the url of the currently selected pod. fixes artemiscloud#192
lavocatt
force-pushed
the
multiplepemhost
branch
from
e280d75
to
06d0fee
Compare
Msarawan
reviewed
Aug 20, 2024
Msarawan
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple hosts to be exposed via an ingress when the user selects several replicas. Each pod gets exposed and has its own url to get connected to.
The connectivity helper shows the url of the currently selected pod.
fixes #192