Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1007] respect deployed resource on PVC reconcile and fill in volume… #1010

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[#1007] respect deployed resource on PVC reconcile and fill in volume… #1010

merged 1 commit into from
Sep 17, 2024

Conversation

gtully
Copy link
Contributor

@gtully gtully commented Sep 13, 2024

…Mode default

@gtully
Copy link
Contributor Author

gtully commented Sep 13, 2024

Worth some thought is the ObjectMeta in the PVC template, not sure it is good idea.

@gtully gtully requested a review from brusdev September 13, 2024 16:17
brusdev
brusdev approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@brusdev brusdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using one function for both the default PV and the ExtraVolumeClaimTemplates is a great idea!

@brusdev
Copy link
Contributor

brusdev commented Sep 17, 2024

Full test-suite passed

@gtully
Copy link
Contributor Author

gtully commented Sep 17, 2024

Worth some thought is the ObjectMeta in the PVC template, not sure it is good idea.

I am going to leave it, we don't add the same default labels as we do for the persistenceEnabled PVC, so there possibly will be the need to add labels. A resourceTemplate will work in this case also. Maybe it is a good convenience.

@gtully gtully merged commit 7494e84 into artemiscloud:main Sep 17, 2024
2 checks passed
@gtully gtully deleted the _#1007 branch September 17, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusdev brusdev brusdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtully @brusdev