-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated package moving (storage) refs #9910 #22
base: master
Are you sure you want to change the base?
Conversation
Please update the README to describe the new tool. |
common/utils.py
Outdated
# Open PID file only if it doesn't exist for read/write | ||
f = os.fdopen(os.open(pid_file, os.O_CREAT | os.O_EXCL | os.O_RDWR), 'r+') | ||
except OSError,e: | ||
if logger: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to assume the logger exists as a module level variable, rather than passed in. Let's define the logger at the top of the file and not pass it as a parameter to the helper functions.
Looks pretty good! Can you add tests, and verify it works in Python3 as well? I noticed some python2-only syntax. |
702363d
to
532a8bf
Compare
It looks like the code in this branch needs the addition of SS authentication in order to work with SS branch dev/issue-9909-move-endpoint-0_10_0 ( 0.9.x + move endpoint code ) |
839497a
to
8d24594
Compare
- Add SS API key authentication - Add log level configuration - Update README and sample script - Bug fix
- Add SS API key authentication - Add log level configuration - Update README and sample script - Bug fix
8d24594
to
fe30c09
Compare
Script for automating moving of packages from one location to another: