Automated package moving (storage) refs #9910 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the README to describe the new tool. |
common/utils.py
Outdated
| # Open PID file only if it doesn't exist for read/write | ||
| f = os.fdopen(os.open(pid_file, os.O_CREAT | os.O_EXCL | os.O_RDWR), 'r+') | ||
| except OSError,e: | ||
| if logger: |
There was a problem hiding this comment.
It makes more sense to assume the logger exists as a module level variable, rather than passed in. Let's define the logger at the top of the file and not pass it as a parameter to the helper functions.
|
Looks pretty good! Can you add tests, and verify it works in Python3 as well? I noticed some python2-only syntax. |
qubot
force-pushed
the
dev/issue-9910-storage
branch
from
702363d
to
532a8bf
Compare
|
It looks like the code in this branch needs the addition of SS authentication in order to work with SS branch dev/issue-9909-move-endpoint-0_10_0 ( 0.9.x + move endpoint code ) |
qubot
force-pushed
the
dev/issue-9910-storage
branch
from
839497a
to
8d24594
Compare
qubot
pushed a commit
that referenced
this pull request
Oct 11, 2016
- Add SS API key authentication - Add log level configuration - Update README and sample script - Bug fix
hakamine
changed the title
hakamine
changed the title
- Add SS API key authentication - Add log level configuration - Update README and sample script - Bug fix
qubot
force-pushed
the
dev/issue-9910-storage
branch
from
8d24594
to
fe30c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script for automating moving of packages from one location to another: