Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API key generation when user edits are disabled #2004

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Fix API key generation when user edits are disabled #2004

merged 7 commits into from
Oct 25, 2024

Commits on Oct 22, 2024

  1. Add type hints for test_administration module

    @replaceafill
    replaceafill committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    92bab23 View commit details
    Browse the repository at this point in the history

  2. Add tests for general view

    @replaceafill
    replaceafill committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    31947f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add type hints for accounts.test_views module

    @replaceafill
    replaceafill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d8ed2d0 View commit details
    Browse the repository at this point in the history

  2. Add tests for edit user view

    @replaceafill
    replaceafill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    be74df8 View commit details
    Browse the repository at this point in the history

  3. Add tests for user profile view

    @replaceafill
    replaceafill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1834ac4 View commit details
    Browse the repository at this point in the history

  4. Add test for not requesting API key generation 

    This test submits the user profile form leaving the "Regenerate API
key" field unchecked.

The test fails because the API key is always updated on POST
submission when the ALLOW_USER_EDITS setting is False.
    @replaceafill
    replaceafill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5e80b3f View commit details
    Browse the repository at this point in the history

  5. Fix failing test 

    This updates the ApiKeyForm to use boolean values instead of
characters and the profile view to use the cleaned_data attribute of
the form to check if API key regeneration was requested.
    @replaceafill
    replaceafill committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    eb8011b View commit details
    Browse the repository at this point in the history