Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to the characterize_file script #1980

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

replaceafill
Copy link
Member

This also removes an unnecessary argument from the workflow definition and adds a typed argument parser to the script.

@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Aug 20, 2024
This also removes an unnecessary argument from the workflow definition
and adds a typed argument parser to the script.
@replaceafill replaceafill force-pushed the dev/add-type-hints-characterize-file branch from 6f004b5 to 888aa4e Compare August 20, 2024 15:57
@replaceafill replaceafill added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Aug 20, 2024
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@replaceafill replaceafill merged commit 8742013 into qa/1.x Aug 20, 2024
45 checks passed
@replaceafill replaceafill deleted the dev/add-type-hints-characterize-file branch August 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants