Extend test coverage of policy check #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-of-policy-check
branch
from
7cce3b2
to
78bef8b
Compare
workflow.json always passes the shared path and file type arguments, so they can become required arguments.
Dhwaniartefact
force-pushed
the
dev/issue-extend-test-coverage-of-policy-check
branch
from
78bef8b
to
00d91ee
Compare
Dhwaniartefact
requested review from
replaceafill
and removed request for
replaceafill
replaceafill
requested changes
Aug 14, 2024
tests/MCPClient/test_policy_check.py
Outdated
| sip_file_format_version: models.FileFormatVersion, | ||
| format: fprmodels.Format, | ||
| format_version: fprmodels.FormatVersion, | ||
| shared_directory_path: str, |
There was a problem hiding this comment.
This fixture returns a pathlib.Path object:
archivematica/tests/MCPClient/conftest.py
Line 216 in 01293dc
tests/MCPClient/test_policy_check.py
Outdated
| str(access_file.uuid), | ||
| str(sip.uuid), | ||
| str(shared_directory_path), | ||
| "access", |
There was a problem hiding this comment.
The preservation case of this test is using the filegrpuse attribute instead of a hard coded string.
replaceafill
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks @Dhwaniartefact. You missed a couple of observations, but I made suggestions for those.
tests/MCPClient/test_policy_check.py
Outdated
| sip_file_format_version: models.FileFormatVersion, | ||
| format: fprmodels.Format, | ||
| format_version: fprmodels.FormatVersion, | ||
| shared_directory_path: str, |
There was a problem hiding this comment.
Suggested change
| shared_directory_path: str, | |
| shared_directory_path: pathlib.Path, |
tests/MCPClient/test_policy_check.py
Outdated
| str(access_file.uuid), | ||
| str(sip.uuid), | ||
| str(shared_directory_path), | ||
| "access", |
There was a problem hiding this comment.
Suggested change
| "access", | |
| access_file.filegrpuse, |
Dhwaniartefact
requested review from
replaceafill
and removed request for
replaceafill
Dhwaniartefact
deleted the
dev/issue-extend-test-coverage-of-policy-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to the
policy_checkscript and its tests.