Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid UUID on queries #1835

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Handle invalid UUID on queries #1835

merged 1 commit into from
Aug 23, 2023

Conversation

Dhwaniartefact
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact requested review from replaceafill and removed request for replaceafill August 21, 2023 20:42
@Dhwaniartefact Dhwaniartefact force-pushed the dev/issue-1280-validationerror-handling branch 2 times, most recently from 6c3af4e to e7db08b Compare August 22, 2023 17:13
@Dhwaniartefact Dhwaniartefact added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Aug 22, 2023
replaceafill
replaceafill requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Dhwaniartefact, just left some questions.

src/MCPClient/lib/clientScripts/create_sip_from_transfer_objects.py Outdated Show resolved Hide resolved
src/MCPClient/lib/clientScripts/create_transfer_mets.py Outdated Show resolved Hide resolved
src/MCPClient/lib/clientScripts/dip_generation_helper.py Outdated Show resolved Hide resolved
src/MCPClient/lib/clientScripts/parse_mets_to_db.py Outdated Show resolved Hide resolved
src/dashboard/src/components/access/views.py Outdated Show resolved Hide resolved
src/dashboard/src/components/access/views.py Outdated Show resolved Hide resolved
src/dashboard/src/components/access/views.py Outdated Show resolved Hide resolved
src/dashboard/src/components/access/views.py Outdated Show resolved Hide resolved
src/dashboard/src/components/transfer/views.py Outdated Show resolved Hide resolved
src/dashboard/src/fpr/utils.py Outdated Show resolved Hide resolved
@Dhwaniartefact Dhwaniartefact force-pushed the dev/issue-1280-validationerror-handling branch from e7db08b to 9c98e9a Compare August 22, 2023 21:59
@Dhwaniartefact Dhwaniartefact added AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests and removed AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests labels Aug 22, 2023
@Dhwaniartefact Dhwaniartefact merged commit bcbb545 into qa/1.x Aug 23, 2023
29 checks passed
@Dhwaniartefact Dhwaniartefact deleted the dev/issue-1280-validationerror-handling branch August 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@replaceafill replaceafill replaceafill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dhwaniartefact @replaceafill