Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide various custom structMap examples #52

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

ross-spencer
Copy link
Contributor

@ross-spencer ross-spencer commented Apr 8, 2019

This commit adds a number of custom structMap examples to the
Archivematica sample-data to demonstrate the different
configurations of the feature for future users, and testing
purposes.

Connected to archivematica/Issues#283

cc. @peterVG If you spot any enhancements we can make to improve these samples for users and what they're doing, we can probably make those changes in this branch as well.

@ross-spencer ross-spencer self-assigned this Apr 8, 2019
@ross-spencer ross-spencer changed the title WIP: Provide various custom structMap examples Provide various custom structMap examples Apr 13, 2019
@peterVG peterVG self-requested a review April 23, 2019 19:25
<mets:fptr FILEID="page_07.jpg" CONTENTIDS="objects/page_07.jpg"/>
</mets:div>
</mets:div>
<!-- Subchapter 1.2 -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why Subchapter 1.2 is nested inside Subchapter 1.1 instead of appearing at the same hierarchical level (i.e. as a sibling level)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot. That was an oversight on my part, quite literally, I couldn't differentiate the levels. I have added a new commit to correct each of the three book examples. I'll submit for re-review to get the thumbs up before merging.

Copy link

@peterVG peterVG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All structMap examples in this PR were tested successfully on AM 1.10/qa. AM assigned unique IDs to the structMap and mapped the files in the /objects directory to mets:fptr elements using the UUIDs assigned by AM.

Copy link

@peterVG peterVG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the subchapter divs, Ross. LGTM!

This commit introduces a number of customStructmap example
transfers for reference and testing. These structMaps are inline
with the feature as is being refurbished/introduced into
Archivematica 1.10.
@ross-spencer ross-spencer force-pushed the dev/issue-283-structmap-development branch from 29f9d88 to ca89390 Compare April 26, 2019 08:47
@ross-spencer ross-spencer merged commit ca89390 into master Apr 26, 2019
@ross-spencer ross-spencer deleted the dev/issue-283-structmap-development branch April 26, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants