Create a mechanism to provide a custom FILEID #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-spencer
force-pushed
the
dev/issue-660-enable-use-of-fileid
branch
from
142fa79
to
9931ae5
Compare
ross-spencer
changed the title
cole
reviewed
Jun 13, 2019
There was a problem hiding this comment.
One thing that could lead to confusion here is the similarity between FSEntry.fileid (the new attribute) and FSEntry.file_id (the property). What about using _fileid for the new one, to communicate that the property should be used for access?
Otherwise this looks good.
cole
approved these changes
Jun 13, 2019
|
I hadn't even hit re-reivew!! 😄 though I appreciate it! Thanks @cole will get this merged and published today and finalize subsequent changes to the Storage Service. |
Enable mets-reader-writer to output a FILEID for a METS document that isn't automatically generated using another component provided to the FSENTRY constructor.
ross-spencer
force-pushed
the
dev/issue-660-enable-use-of-fileid
branch
from
d31a277
to
9ab6410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable mets-reader-writer to output a FILEID for a METS document that
isn't automatically generated using another component provided to the
FSENTRY constructor.
Connected to archivematica/Issues#660
Required by artefactual/archivematica-storage-service#467