Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request-scoped processing config #85

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add request-scoped processing config #85

merged 1 commit into from
Oct 27, 2020

Conversation

sevein
Copy link
Member

@sevein sevein commented Oct 27, 2020

This commit removes support for processingMCP.xml. Instead, users are
asked to submit the processing configuration via the API. The workflow
had a couple of now unused link types removed and added a new LinkChoice
type removing the need of workflow chains.

Fixes #76.

@codecov-io
Copy link

Codecov Report

Merging #85 into main will decrease coverage by 0.24%.
The diff coverage is 49.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   46.41%   46.17%   -0.25%     
==========================================
  Files         108      106       -2     
  Lines        8014     7822     -192     
  Branches     1051     1030      -21     
==========================================
- Hits         3720     3612     -108     
+ Misses       4115     4035      -80     
+ Partials      179      175       -4     
Impacted Files Coverage Δ
a3m/cli/client/__main__.py 0.00% <0.00%> (ø)
a3m/cli/client/wrapper.py 0.00% <ø> (ø)
a3m/client/clientScripts/a3m_download_transfer.py 0.00% <0.00%> (ø)
...lient/clientScripts/assign_uuids_to_directories.py 0.00% <0.00%> (ø)
a3m/client/clientScripts/compress_aip.py 0.00% <0.00%> (ø)
.../clientScripts/create_sip_from_transfer_objects.py 0.00% <ø> (ø)
a3m/client/clientScripts/identify_file_format.py 0.00% <0.00%> (ø)
a3m/client/clientScripts/verify_sip_compliance.py 0.00% <0.00%> (ø)
...client/clientScripts/verify_transfer_compliance.py 0.00% <0.00%> (ø)
a3m/executeOrRunSubProcess.py 42.02% <ø> (-2.90%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0566dcf...98f05f1. Read the comment docs.

This commit removes support for processingMCP.xml. Instead, users are
asked to submit the processing configuration via the API. The workflow
had a couple of now unused link types removed and added a new LinkChoice
type removing the need of workflow chains.

Fixes #76.
@sevein sevein force-pushed the dev/processing-config branch from 98f05f1 to e2dbb6c Compare October 27, 2020 16:31
@sevein sevein merged commit adb7fb1 into main Oct 27, 2020
@sevein sevein deleted the dev/processing-config branch October 27, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: processingMCP seems to be ignored
2 participants