Fix API image URL generation for max width #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftingly
commented
May 7, 2024
| @@ -62,15 +65,15 @@ private function getOverrideImages(array $image): array | |||
| ), | |||
| ], | |||
| 'img_medium' => [ | |||
| 'url' => $image['original'].'?fm=jpg&q=80&fit=max&dpr=1&w=843', | |||
| 'url' => $image['original'].'?fm=jpg&q=80&fit=max&dpr=1&w='.static::IMAGE_SIZES['medium'], | |||
|
zachgarwood
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with API image URLs when the provided image is below the preferred image dimensions.
Even though we were setting the width correctly for the width key, the URL was still being generated with the preferred width.
Before:
After:
I also cleaned up some uses of the spread operator to make it a bit more readable.