Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve seeder validation output #34

Merged
merged 2 commits into from
May 9, 2024
Merged

Improve seeder validation output #34

merged 2 commits into from
May 9, 2024

Conversation

driftingly
Copy link
Contributor

This PR improves the output of the seeder validator to help when manually checking potential issues.

Theme: Let’s Play
Prompt: Hide and Seek 
Artwork: A33: "Middletown" Parlor, 1875-90
EN ID: 409 Img: http://journeymaker.artic.edu//sites/default/files/45407.jpg
ZH ID: 1594 Img: http://journeymaker.artic.edu//sites/default/files/Middletown-Parlor.jpg
Similarity: 40

nikhiltri
nikhiltri approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ⭐

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@driftingly driftingly merged commit 1e51639 into develop May 9, 2024
2 checks passed
@driftingly driftingly deleted the drift/add-fields-seeder-validation branch May 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgarwood zachgarwood zachgarwood approved these changes

@nikhiltri nikhiltri nikhiltri approved these changes

@web-dev-trev web-dev-trev Awaiting requested review from web-dev-trev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftingly @nikhiltri @zachgarwood