Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API thumbnail over DIM service #22

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

driftingly
Copy link
Contributor

This PR removes the Digital Asset Management System Image Service class in favour of using thumbnail data from the API. Since we are getting this image information with the other API information we no longer need a separate cron to cache the responses from DAMS.

This not only simplifies how image URLs are generated, but it also speeds up the generation of the JSON to under 10 seconds.

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⭐

I'll be curious to see how big of images the FE ends up trying to display. We could make some tweaks here to optimize performance, but this looks like it should do tot he trick to give the FE all the data it needs to function.

Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@driftingly driftingly merged commit 84291ca into develop May 2, 2024
2 checks passed
@driftingly driftingly deleted the drift/remove-dim-service branch May 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants