Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field limits and image validation #21

Merged
merged 4 commits into from
May 1, 2024

Conversation

driftingly
Copy link
Contributor

This PR updates the field limits and adds additional image validation.

Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the hints don't match the validation rules. But outside of that looks good! Marking this as approve, go ahead and consider this a thumbs up to merge once that small detail is fixed.

Screenshot 2024-05-01 at 4 45 44 PM

@nikhiltri nikhiltri requested a review from zachgarwood May 1, 2024 21:47
Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@driftingly
Copy link
Contributor Author

Some of the hints don't match the validation rules. But outside of that looks good! Marking this as approve, go ahead and consider this a thumbs up to merge once that small detail is fixed.

Screenshot 2024-05-01 at 4 45 44 PM

Thanks @nikhiltri I was showing Jeanne how we could add notes and didn't mean for that to make it through. I think it's worth including so I updated and added them to the other fields.

@driftingly driftingly merged commit 988020a into develop May 1, 2024
2 checks passed
@driftingly driftingly deleted the drift/update-field-limits branch May 1, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants