Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to artwork #20

Merged
merged 3 commits into from
May 1, 2024
Merged

Add filters to artwork #20

merged 3 commits into from
May 1, 2024

Conversation

driftingly
Copy link
Contributor

This PR adds filtering to artwork and cleans up theme quick filters.

Screenshot 2024-04-30 at 10 05 03 PM Screenshot 2024-04-30 at 10 05 16 PM Screenshot 2024-04-30 at 10 05 26 PM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run this locally the on view and published filters work as expected, but theme filter throws an error in the console:

Object { message: "SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'position' in order clause is ambiguous (Connection: mysql, SQL: select count(*) as aggregate from `artworks` where exists (select * from `theme_prompts` inner join `theme_prompt_artworks` on `theme_prompt_artworks`.`theme_prompt_id` = `theme_prompts`.`id` where `artworks`.`id` = `theme_prompt_artworks`.`artwork_id` and exists (select * from `themes` where `theme_prompts`.`theme_id` = `themes`.`id` and `id` = 1 and `themes`.`deleted_at` is null order by `position` asc) and `theme_prompts`.`deleted_at` is null and `theme_prompt_artworks`.`deleted_at` is null order by `position` asc) and `is_on_view` = 1 and `published` = 1 and `artworks`.`deleted_at` is null)", exception: "Illuminate\\Database\\QueryException", file: "/home/vagrant/journeymaker-cms/vendor/laravel/framework/src/Illuminate/Database/Connection.php", line: 829, trace: (67) […] }

Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Base automatically changed from drift/sort-prompts to develop May 1, 2024 16:37
@driftingly driftingly requested a review from nikhiltri May 1, 2024 16:54
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⭐

@driftingly driftingly merged commit 9454a8a into develop May 1, 2024
2 checks passed
@driftingly driftingly deleted the drift/filter-artwork branch May 1, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants