-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filters to artwork #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run this locally the on view and published filters work as expected, but theme filter throws an error in the console:
Object { message: "SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'position' in order clause is ambiguous (Connection: mysql, SQL: select count(*) as aggregate from `artworks` where exists (select * from `theme_prompts` inner join `theme_prompt_artworks` on `theme_prompt_artworks`.`theme_prompt_id` = `theme_prompts`.`id` where `artworks`.`id` = `theme_prompt_artworks`.`artwork_id` and exists (select * from `themes` where `theme_prompts`.`theme_id` = `themes`.`id` and `id` = 1 and `themes`.`deleted_at` is null order by `position` asc) and `theme_prompts`.`deleted_at` is null and `theme_prompt_artworks`.`deleted_at` is null order by `position` asc) and `is_on_view` = 1 and `published` = 1 and `artworks`.`deleted_at` is null)", exception: "Illuminate\\Database\\QueryException", file: "/home/vagrant/journeymaker-cms/vendor/laravel/framework/src/Illuminate/Database/Connection.php", line: 829, trace: (67) […] }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! ⭐
This PR adds filtering to artwork and cleans up theme quick filters.